pierre/wallabag
1
0
Fork 0
forked from wallabag/wallabag
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

Inject parameter instead of service

Browse Source 
We are injecting CraueConfig service when we only need to retrieve one or two values from it.
Instead I discovered we can directly inject a value from a service in the service definition!
This commit is contained in:
Jeremy Benoist
2016-10-30 20:27:41 +01:00
parent f74061f1e1
commit 4b3c983ab8
5 changed files with 11 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/Wallabag/CoreBundle/Helper/EntriesExport.php
View File

@ -8,7 +8,6 @@ use JMS\Serializer\SerializerBuilder;
use PHPePub\Core\EPub;
use PHPePub\Core\Structure\OPF\DublinCore;
use Symfony\Component\HttpFoundation\Response;
use Craue\ConfigBundle\Util\Config;
/**
* This class doesn't have unit test BUT it's fully covered by a functional test with ExportControllerTest.
@ -27,12 +26,12 @@ class EntriesExport
</div>';
/**
* @param Config $craueConfig CraueConfig instance to get wallabag instance url from database
* @param string $wallabagUrl Wallabag instance url
* @param string $logoPath Path to the logo FROM THE BUNDLE SCOPE
*/
public function __construct(Config $craueConfig, $logoPath)
public function __construct($wallabagUrl, $logoPath)
{
$this->wallabagUrl = $craueConfig->get('wallabag_url');
$this->wallabagUrl = $wallabagUrl;
$this->logoPath = $logoPath;
}