pierre/wallabag
1
0
Fork 0
forked from wallabag/wallabag
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

Use two indexes instead of one for hashed urls

Browse Source 
When using `OR` in a where clause, a composite index can't be used. We should use a `UNION` to take advantages of it.
Instead, create 2 indexes on each hashed urls and make 2 queries to find an url. It'll be faster than the previous solution.
This commit is contained in:
Jeremy Benoist
2019-06-05 10:51:06 +02:00
parent f3bfb875e9
commit 70df4c3359
4 changed files with 20 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
app/DoctrineMigrations/Version20190601125843.php
View File

@ -30,27 +30,8 @@ class Version20190601125843 extends WallabagMigration
]);
}
$entryTable->dropIndex('hashed_url_user_id');
$entryTable->addIndex(
[
'user_id',
'hashed_url',
'hashed_given_url',
],
'hashed_urls_user_id',
[],
[
// specify length for index which is required by MySQL on text field
'lengths' => [
// user_id
null,
// hashed_url
40,
// hashed_given_url
40,
],
]
);
// 40 = length of sha1 field hashed_given_url
$entryTable->addIndex(['user_id', 'hashed_given_url'], 'hashed_given_url_user_id', [], ['lengths' => [null, 40]]);
}
/**
@ -68,7 +49,6 @@ class Version20190601125843 extends WallabagMigration
$entryTable->dropColumn('hashed_given_url');
}
$entryTable->dropIndex('hashed_urls_user_id');
$entryTable->addIndex(['user_id', 'hashed_url'], 'hashed_url_user_id', [], ['lengths' => [null, 40]]);
$entryTable->dropIndex('hashed_given_url_user_id');
}
}