pierre/wallabag
1
0
Fork 0
forked from wallabag/wallabag
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

Add a validator on URL entity

Browse Source
This commit is contained in:
Nicolas Lœuillet
2023-08-29 14:17:53 +02:00
parent ec4d23b584
commit 94303c92e6
5 changed files with 75 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
tests/Wallabag/ApiBundle/Controller/EntryRestControllerTest.php
View File

@ -509,6 +509,25 @@ class EntryRestControllerTest extends WallabagApiTestCase
$this->assertSame(400, $this->client->getResponse()->getStatusCode());
}
public function testBadFormatURL()
{
$this->client->request('POST', '/api/entries.json', [
'url' => 'wallabagIsAwesome',
'tags' => 'google',
'title' => 'New title for my article',
'content' => 'my content',
'language' => 'de',
'published_at' => '2016-09-08T11:55:58+0200',
'authors' => 'bob,helen',
'public' => 1,
]);
$this->assertSame(200, $this->client->getResponse()->getStatusCode());
$content = json_decode($this->client->getResponse()->getContent(), true);
$this->assertStringContainsString('The url \'"wallabagIsAwesome"\' is not a valid url', $content);
}
public function testPostEntry()
{
$this->client->request('POST', '/api/entries.json', [

37
tests/Wallabag/CoreBundle/Controller/EntryControllerTest.php
View File

@ -20,6 +20,7 @@ class EntryControllerTest extends WallabagCoreTestCase
public const AN_URL_CONTAINING_AN_ARTICLE_WITH_IMAGE = 'https://www.lemonde.fr/judo/article/2017/11/11/judo-la-decima-de-teddy-riner_5213605_1556020.html';
public $downloadImagesEnabled = false;
public $url = 'https://www.lemonde.fr/pixels/article/2019/06/18/ce-qu-il-faut-savoir-sur-le-libra-la-cryptomonnaie-de-facebook_5477887_4408996.html';
public $wrongUrl = 'wallabagIsAwesome';
private $entryDataTestAttribute = '[data-test="entry"]';
/**
@ -137,9 +138,7 @@ class EntryControllerTest extends WallabagCoreTestCase
$crawler = $client->submit($form);
$this->assertSame(200, $client->getResponse()->getStatusCode());
$this->assertCount(1, $alert = $crawler->filter('form ul li')->extract(['_text']));
$this->assertSame('This value should not be blank.', $alert[0]);
$this->assertSame(302, $client->getResponse()->getStatusCode());
}
/**
@ -423,6 +422,38 @@ class EntryControllerTest extends WallabagCoreTestCase
$em->flush();
}
/**
* @group NetworkCalls
*/
public function testBadFormatURL()
{
$this->logInAs('admin');
$client = $this->getTestClient();
$client->getContainer()->get(Config::class)->set('store_article_headers', 1);
$crawler = $client->request('GET', '/new');
$this->assertSame(200, $client->getResponse()->getStatusCode());
$form = $crawler->filter('form[name=entry]')->form();
$data = [
'entry[url]' => $this->wrongUrl,
];
$client->submit($form, $data);
$this->assertSame(302, $client->getResponse()->getStatusCode());
$content = $client->getContainer()
->get(EntityManagerInterface::class)
->getRepository(Entry::class)
->findByUrlAndUserId($this->wrongUrl, $this->getLoggedInUserId());
$this->assertFalse($content);
}
public function testArchive()
{
$this->logInAs('admin');